Fetch api update #82
Merged
Fetch api update #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requests are now processed using the fetch API Response Handler needs some refactoring to handle the error vs bad response
Switch to isomorphic fetch
User headers now overwrite default headers
Changed [string] to string[], fixed spacing, fixed double parens
…om U-FAREAST\ramgupt
Use the Fetch API instead of SuperAgent to communicate with MS Graph
Contributor
Author
|
@lahuey the pull request 63 was opened against fetchApiUpdate branch. When I merged that, it got merged into this branch. Was there a reason to open that pull request against this branch? Eventually we need to merge the code into dev, so I have opened this pull request. If there is some other way in your mind, please let us know else kindly resolve the conflicts in this pr, so that we can merge this. @MIchaelMainer : I hope pull request that we open is against the branch that is meant for release? |
|
I pushed the non blocking changes literally a couple minutes after you
merged my change. Please ignore/close my pull request if possible.
…On Wed, Jun 20, 2018, 9:24 PM Raman Gupta ***@***.***> wrote:
@lahuey <https://github.com/lahuey> the pull request 63 was opened
against fetchApiUpdate branch. When I merged that, it got merged into this
branch. Was there a reason to open that pull request again this branch?
Eventually we need to merge the code into dev, so I have opened this pull
request. If there is some other way in your mind, please let us know else
kindly resolve the conflicts in this pr, so that we can merge this.
@MIchaelMainer <https://github.com/MIchaelMainer> @muthurathinam
<https://github.com/muthurathinam>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHBvHBtD1h53_pxgswG5aWmx1lo-LqSzks5t-x_CgaJpZM4UxYBf>
.
|
added 2 commits
June 28, 2018 09:55
muthurathinam
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.