Reuse HTTP Client In Session #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peombwa
requested review from
ddyett,
georgend,
shemogumbe and
timayabi2020
as code owners
ddyett
reviewed
Apr 7, 2022
timayabi2020
approved these changes
Apr 8, 2022
Merged
peombwa
added a commit
that referenced
this pull request
Apr 11, 2022
* Weekly OpenApiDocs Download (#1136) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Create projectsbot.yml Adds a yaml file for adding issues to the project board * Docs Generation (#1138) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for Devices.CloudPrint [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for DeviceManagement.Enrolment [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for Files [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for CrossDeviceExperiences [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for DirectoryObjects [run ci] * Docs Generation for ChangeNotifications [run ci] * Docs Generation for Bookings [run ci] * Docs Generation for Identity.DirectoryManagement [run ci] * Docs Generation for Education [run ci] * Docs Generation for Users [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for DeviceManagement [run ci] * Docs Generation for Teams [run ci] * Docs Generation for Security [run ci] * Docs Generation for Groups [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Weekly OpenApiDocs Download (#1151) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Docs Generation (#1152) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for DeviceManagement.Functions [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for Education [run ci] * Docs Generation for Devices.CloudPrint [run ci] * Docs Generation for Compliance [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for Files [run ci] * Docs Generation for Groups [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for Security [run ci] * Docs Generation for ChangeNotifications [run ci] * Docs Generation for DeviceManagement.Enrolment [run ci] * Docs Generation for DeviceManagement.Actions [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Applications [run ci] * Docs Generation for Users [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Chnage build agent. (#1157) * Weekly OpenApiDocs Download (#1170) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Update Get-MgApplication.md (#1160) Examples 4 and 5 had users in the description. Corrected that to applications. Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Docs Generation (#1172) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for CloudCommunications [run ci] * Docs Generation for Files [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for Identity.DirectoryManagement [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for DeviceManagement.Functions [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for Reports [run ci] * Docs Generation for DeviceManagement.Administration [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Education [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for DeviceManagement [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for Applications [run ci] * Docs Generation for Groups [run ci] * Docs Generation for Users [run ci] * Docs Generation for Teams [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Weekly OpenApiDocs Download (#1180) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Docs Generation (#1181) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for Identity.DirectoryManagement [run ci] * Docs Generation for Teams [run ci] * Docs Generation for Applications [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for Compliance [run ci] * Docs Generation for Files [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Groups [run ci] * Docs Generation for Search [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for Education [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for Users [run ci] * Docs Generation for DeviceManagement [run ci] * Docs Generation for Security [run ci] * Docs Generation for Devices.CloudPrint [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Enable Test-MgGroupDynamicMembershipRule command. (#1142) * supress Invoke-MgFilterEntitlementManagementCatalogAccessPackage (#1190) Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * add to beta profile (#1189) Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Fixes Missing `-Debug` Request Body in PS 5.1 (#1179) * Fall back to OnBeforeCall in PS 5.1. * Add Pester tests. * Use PSHostVersion to detect PS edition. * Reuse session HTTP client. (#1184) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: DeVere Dyett <ddyett@microsoft.com> Co-authored-by: K N Manoj Reddy <44399320+ManojReddy-MSFT@users.noreply.github.com> Co-authored-by: Mark Wahl <mwahl@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1108 by ensuring we initialize the HTTP client only once per session and reuse it for subsequent calls to the service. The PR also adds unit tests to validate the change on NET4x and NETCore.
The following charts show the network connection count trend (
netstat -an) when you runGet-MgSecuritySecureScore50 times.TCP Connection Count in PS 5.1 (before the fix)
TCP Connection Count in PS 5.1 (after the fix)
Notes:
From my testing, PS 7 automatically closes the connection after each request. Thus, the socket exhaustion issue is only present in PS 5.1 and Azure Automation Runbook, which runs on PS 5.1 and has a max socket limit of 1000.
