Identity governance custom cmdlets: ensure existing cmdlets with the same names are only loaded in beta profile (for now) #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwahl-msft
requested review from
ddyett,
georgend,
peombwa,
shemogumbe and
timayabi2020
as code owners
peombwa
approved these changes
Apr 5, 2022
Contributor
Author
|
#sign-off |
Merged
peombwa
added a commit
that referenced
this pull request
Apr 11, 2022
* Weekly OpenApiDocs Download (#1136) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Create projectsbot.yml Adds a yaml file for adding issues to the project board * Docs Generation (#1138) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for Devices.CloudPrint [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for DeviceManagement.Enrolment [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for Files [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for CrossDeviceExperiences [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for DirectoryObjects [run ci] * Docs Generation for ChangeNotifications [run ci] * Docs Generation for Bookings [run ci] * Docs Generation for Identity.DirectoryManagement [run ci] * Docs Generation for Education [run ci] * Docs Generation for Users [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for DeviceManagement [run ci] * Docs Generation for Teams [run ci] * Docs Generation for Security [run ci] * Docs Generation for Groups [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Weekly OpenApiDocs Download (#1151) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Docs Generation (#1152) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for DeviceManagement.Functions [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for Education [run ci] * Docs Generation for Devices.CloudPrint [run ci] * Docs Generation for Compliance [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for Files [run ci] * Docs Generation for Groups [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for Security [run ci] * Docs Generation for ChangeNotifications [run ci] * Docs Generation for DeviceManagement.Enrolment [run ci] * Docs Generation for DeviceManagement.Actions [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Applications [run ci] * Docs Generation for Users [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Chnage build agent. (#1157) * Weekly OpenApiDocs Download (#1170) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Update Get-MgApplication.md (#1160) Examples 4 and 5 had users in the description. Corrected that to applications. Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Docs Generation (#1172) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for CloudCommunications [run ci] * Docs Generation for Files [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for Identity.DirectoryManagement [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for DeviceManagement.Functions [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for Reports [run ci] * Docs Generation for DeviceManagement.Administration [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Education [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for DeviceManagement [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for Applications [run ci] * Docs Generation for Groups [run ci] * Docs Generation for Users [run ci] * Docs Generation for Teams [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Weekly OpenApiDocs Download (#1180) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> * Docs Generation (#1181) * Weekly OpenApiDocs Download. [run ci] * Add generated MgCommandMetadata.json. [run ci] * Docs Generation for Identity.DirectoryManagement [run ci] * Docs Generation for Teams [run ci] * Docs Generation for Applications [run ci] * Docs Generation for Devices.CorporateManagement [run ci] * Docs Generation for Compliance [run ci] * Docs Generation for Files [run ci] * Docs Generation for Identity.SignIns [run ci] * Docs Generation for Sites [run ci] * Docs Generation for Groups [run ci] * Docs Generation for Search [run ci] * Docs Generation for Users.Functions [run ci] * Docs Generation for Users.Actions [run ci] * Docs Generation for Education [run ci] * Docs Generation for Identity.Governance [run ci] * Docs Generation for Users [run ci] * Docs Generation for DeviceManagement [run ci] * Docs Generation for Security [run ci] * Docs Generation for Devices.CloudPrint [run ci] Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Enable Test-MgGroupDynamicMembershipRule command. (#1142) * supress Invoke-MgFilterEntitlementManagementCatalogAccessPackage (#1190) Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * add to beta profile (#1189) Co-authored-by: Peter Ombwa <peombwa@microsoft.com> * Fixes Missing `-Debug` Request Body in PS 5.1 (#1179) * Fall back to OnBeforeCall in PS 5.1. * Add Pester tests. * Use PSHostVersion to detect PS edition. * Reuse session HTTP client. (#1184) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Microsoft Graph DevX Tooling <GraphTooling@service.microsoft.com> Co-authored-by: DeVere Dyett <ddyett@microsoft.com> Co-authored-by: K N Manoj Reddy <44399320+ManojReddy-MSFT@users.noreply.github.com> Co-authored-by: Mark Wahl <mwahl@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
In the identity governance Graph API for entitlement management, some resource type paths are different between beta and v1.0, and some structures are different between beta and v1.0.
In the identity governance module, some of the custom cmdlets have names that correspond to their Graph paths. As a result, some are for beta only, for instance
Get-MgEntitlementManagementAccessPackageAssignment.ps1and others for v1.0 only, for instanceGet-MgEntitlementManagementAssignment.ps1, set with theMicrosoft.Graph.PowerShell.Profile.For the
AccessPackageandConnectedOrganizationresource types, the names of the Graph paths are the same between beta and v1.0, but the resource type structures generated from Graph for those two are different, with different field and relationship names. Currently there are four custom cmdlets that were written originally for beta, but because they don't have aMicrosoft.Graph.PowerShell.Profile, those appear in the 1.9.3 v1.0 module for both v1.0 and beta. Unfortunately, when they're loaded for v1.0, they call beta Graph APIs and return the beta version of the structures. In order to prevent beta APIs from being inadvertently called and confusing the caller, this PR temporarily changes those four cmdlets to only be in beta profile.A later PR for these would allow those four cmdlets to also be used in v1.0 with the v1.0 resource type structures, that PR would be substantially bigger than this one as it would need to call different private APIs internally, and have different output types depending on whether the beta or v1.0 profile was selected..