-
Notifications
You must be signed in to change notification settings - Fork 10
Migrate sites, workers, device-users, users, security-groups, and email-recipients to actions menu pattern #7307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
|
@copilot We are missing imports in the modules files for the actions menu to be shown correctly, compare with existing modules before the migration, |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Added the missing MatMenu, MatMenuItem, and MatMenuTrigger imports to all affected module files:
Build verified successfully. Commit: a0a9219 |
|
@copilot after the changes to device user, we have these errors: |
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
... Fixed the device users tests. The tests were directly accessing Changes in commit e85f51c:
|
Actions Menu Migration - Complete ✅
This PR successfully migrates six components from inline action buttons to a consistent actions menu design pattern (mat-menu) with updated WDIO and Cypress tests.
Components Migrated:
Implementation Complete:
HTML Templates (6 components)
All templates updated with actions menu pattern using
mat-menuwithmore_verticon.Module Imports (5 modules)
Added MatMenu imports to all affected modules:
WDIO & Cypress Page Objects (8 files)
All row objects updated with
openRowMenu()method and updated operations.WDIO Tests (2 files)
Fixed device users tests that were directly accessing editBtn/deleteBtn:
Testing & Verification:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.