Skip to content

fix: decoding chunks in http event stream #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dinwwwh merged 1 commit into from
Jan 13, 2026
Merged

fix: decoding chunks in http event stream #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions packages/standard-server/src/event-iterator/decoder.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,21 +84,24 @@ describe('decodeEventMessage', () => {
})

describe('eventDecoder', () => {
it('on success', () => {
it('on success with mixed chunks', () => {
const onEvent = vi.fn()

const decoder = new EventDecoder({ onEvent })

decoder.feed('event: message\ndata: hello1\ndata: world\n\n')
decoder.feed('event: message\ndata: hello2\ndata: world\nid: 123\nretry: 10000\n\n')
decoder.feed('event: message\ndata: hello3\ndata: world\nid: 123\nretry: 10000\n\n')

decoder.feed('event: done\n')
decoder.feed('data: hello4\n')
decoder.feed('event: message\n')
decoder.feed('data: hello1\n')
decoder.feed('data: world\n\n')

decoder.feed('event: message\ndata: hello2\ndata: world\n\n')
// NOTE: a chunk contain 1,5 events is important test, carefully when modify
decoder.feed('event: message\ndata: hello3\ndata: world\n\nevent: message\ndata: hello4\n')
decoder.feed('data: world\nid: 123\nretry: 10000\n\nevent: done\ndata: hello5\ndata: world\nid: 123\nretry: 10000\n')
decoder.feed('\n')

decoder.end()

expect(onEvent).toHaveBeenCalledTimes(4)
expect(onEvent).toHaveBeenCalledTimes(5)
expect(onEvent).toHaveBeenNthCalledWith(1, {
data: 'hello1\nworld',
event: 'message',
Expand All @@ -109,22 +112,29 @@ describe('eventDecoder', () => {
expect(onEvent).toHaveBeenNthCalledWith(2, {
data: 'hello2\nworld',
event: 'message',
id: '123',
retry: 10000,
id: undefined,
retry: undefined,
comments: [],
})
expect(onEvent).toHaveBeenNthCalledWith(3, {
data: 'hello3\nworld',
event: 'message',
id: '123',
retry: 10000,
id: undefined,
retry: undefined,
comments: [],
})
expect(onEvent).toHaveBeenNthCalledWith(4, {
data: 'hello4\nworld',
event: 'message',
id: '123',
retry: 10000,
comments: [],
})
expect(onEvent).toHaveBeenNthCalledWith(5, {
data: 'hello5\nworld',
event: 'done',
id: undefined,
retry: undefined,
id: '123',
retry: 10000,
comments: [],
})
})
Expand Down
2 changes: 0 additions & 2 deletions packages/standard-server/src/event-iterator/decoder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ export class EventDecoder {
this.options.onEvent(message)
}
}

this.incomplete = ''
}

end(): void {
Expand Down
Loading