fix: use track.timescale and not movie.timescale#372
Open
Equipo45 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi! Thank you for making this short renderer!
I was trying it with several videos, and I found a little bug. In some places, we are working with different timescales, which can cause a mismatch in timestamps of the rendering of the video leading to this error in the
parser.ts:This is because the movie timescales, in some videos, can be taken from the Audio, and not the video. Here we have an example:
Or you can see it directly in the debug, looking at the timescale of the track and the movie_timescale of the track, which should be working with the same number:
Thank you for contributing to the open-source community!