Skip to content

fix: use track.timescale and not movie.timescale #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Equipo45 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use track.timescale and not movie.timescale #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/2d/src/lib/utils/video/parser/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ async function getFileInfo(uri: string) {
const edits = editsWithoutFps.map(edit => {
const trackDurationInSec = track.duration / track.timescale;
const segmentDurationInSec =
edit.segmentDuration / track.movie_timescale;
edit.segmentDuration / track.timescale;
const segmentFrames =
track.nb_samples * (segmentDurationInSec / trackDurationInSec);
const mediaRate =
Expand Down Expand Up @@ -209,7 +209,7 @@ export class Mp4Parser {
private getSecondDurationOfSegment(edit: Edit) {
const mediaRate = edit.mediaRateInteger + edit.mediaRateFraction / 0xffff;
const duration =
edit.segmentDuration / this.file.getInfo().videoTracks[0].movie_timescale;
edit.segmentDuration / this.file.getInfo().videoTracks[0].timescale;
return duration / mediaRate;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/2d/src/lib/utils/video/parser/segment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export class Segment {

const segmentDurationInSeconds =
this.edit.segmentDuration /
this.file.getInfo().videoTracks[0].movie_timescale;
this.file.getInfo().videoTracks[0].timescale;
const framesToFill = Math.ceil(segmentDurationInSeconds * this.edit.fps);

const height = this.file.getInfo().videoTracks[0].track_height;
Expand Down Expand Up @@ -224,7 +224,7 @@ export class Segment {
// Check if we are past the segment duration.
const segmentDurationInSec =
this.edit.segmentDuration /
this.file.getInfo().videoTracks[0].movie_timescale;
this.file.getInfo().videoTracks[0].timescale;
const segmentEndTime = mediaTimeInSec + segmentDurationInSec;
if (frameTimeInSec > segmentEndTime) {
frame.close();
Expand Down
Loading