Conversation
Deploying ui with
|
| Latest commit: |
90e9d88
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://006c504d.ui-6d0.pages.dev |
| Branch Preview URL: | https://components-for-datavis-nitro.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
Adds new Dropdown capabilities to support DataVis NITRO UI needs (notably searchable and multi-select dropdown behaviors), along with supporting tests/stories and improved jsdom test environment setup.
Changes:
- Extend
Dropdownwith searchable filtering UI and multi-select (checkbox + select-all) behavior. - Add Vitest coverage for searchable and multi-select dropdown behaviors.
- Add a
localStoragemock + per-test cleanup in jsdom test setup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/test/setup.ts |
Adds localStorage mocking logic and clears storage between tests. |
src/components/Dropdown/Dropdown.tsx |
Implements searchable dropdown rendering/filtering and multi-select + select-all support. |
src/components/Dropdown/Dropdown.test.tsx |
Adds unit tests covering search filtering, empty state, multi-select, and select-all behaviors. |
src/components/Dropdown/Dropdown.stories.tsx |
Adds Storybook examples for searchable and multi-select dropdown variants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tvenable-mie
force-pushed
the
components-for-datavis-nitro
branch
from
9f3aab1 to
18b4fc3
Compare
tvenable-mie
force-pushed
the
components-for-datavis-nitro
branch
from
18b4fc3 to
7f956f0
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@tvenable-mie I've opened a new pull request, #148, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: tvenable-mie <6664775+tvenable-mie@users.noreply.github.com> Agent-Logs-Url: https://github.com/mieweb/ui/sessions/8f12a425-8ba8-45a8-8856-0cafc7cebb62
Fix ARIA violation: search input outside `role="menu"` in searchable Dropdown
tvenable-mie
force-pushed
the
components-for-datavis-nitro
branch
from
93e63da to
ddd7359
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
garrity-miepub
left a comment
garrity-miepub
left a comment
There was a problem hiding this comment.
I think this is an awesome enhancement to the dropdown!!
I'm adding some UI widgets that are needed to support the parts of DataVis NITRO that aren't yet using mieweb/ui components — such as searchable dropdowns.