Fix ARIA violation: search input outside role="menu" in searchable Dropdown#148
Merged
tvenable-mie merged 2 commits intocomponents-for-datavis-nitrofrom Mar 25, 2026
Merged
Conversation
Co-authored-by: tvenable-mie <6664775+tvenable-mie@users.noreply.github.com> Agent-Logs-Url: https://github.com/mieweb/ui/sessions/8f12a425-8ba8-45a8-8856-0cafc7cebb62
Deploying ui with
|
| Latest commit: |
6c04e26
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb1318e5.ui-6d0.pages.dev |
| Branch Preview URL: | https://copilot-sub-pr-144.ui-6d0.pages.dev |
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from review on DataVis NITRO components PR
Fix ARIA violation: search input outside Mar 25, 2026
role="menu" in searchable Dropdown
tvenable-mie
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per ARIA spec,
role="menu"must only containmenuitem*descendants. The searchable Dropdown was placing<input type="search">directly inside the menu container, breaking screen reader/keyboard semantics.Changes
Dropdown.tsx: Restructured the open panel into two layers — an outer presentational<div>(visual styles: border, shadow, bg, animation) and an inner<div role="menu">containing only menu items. The search input now lives between them: visually part of the panel, structurally outsiderole="menu".aria-controls={menuId}on the search input (links it to the menu it filters)aria-autocomplete="list"on the search inputtrigger'saria-controlsnow correctly resolves to therole="menu"elementDropdown.test.tsx: Added regression test assertingrole="searchbox"is not a descendant ofrole="menu".📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.