Skip to content

feat(condensed): add condensed view support for ServiceShippingSettings#162

Merged
garrity-miepub merged 2 commits into
mainfrom
feature/condensed-view-service-shipping
Apr 6, 2026
Merged

feat(condensed): add condensed view support for ServiceShippingSettings#162
garrity-miepub merged 2 commits into
mainfrom
feature/condensed-view-service-shipping

Conversation

@garrity-miepub

@garrity-miepub garrity-miepub commented Apr 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add condensed view support (data-slot attributes + condensed CSS overrides) to ServiceShippingSettings.

ServiceShippingSettings

  • ServiceShippingSettings.tsx — 10 data-slots: shipping-settings, shipping-settings-header, shipping-settings-title, shipping-settings-description, shipping-settings-content, shipping-settings-kit-toggle, shipping-settings-address, shipping-settings-section-label, shipping-settings-instructions, shipping-settings-actions
  • Textarea uses min-height/max-height for condensed sizing
  • Address grid gap tightened in condensed mode
  • Content and address section spacing uses margin overrides (not gap) to work with Tailwind space-y-* layout

CSS

~80 lines of condensed overrides in condensed-view.css.

Copilot AI review requested due to automatic review settings April 6, 2026 22:34
@garrity-miepub garrity-miepub marked this pull request as ready for review April 6, 2026 22:34
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Apr 6, 2026

Copy link
Copy Markdown

Deploying ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: be6edee
Status: ✅  Deploy successful!
Preview URL: https://51acf876.ui-6d0.pages.dev
Branch Preview URL: https://feature-condensed-view-servi.ui-6d0.pages.dev

View logs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds condensed-view styling hooks for ServiceShippingSettings so the component can be targeted by src/styles/condensed-view.css in condensed mode.

Changes:

  • Added data-slot attributes throughout ServiceShippingSettings to expose styling hooks for condensed mode.
  • Added new condensed CSS rules for the shipping settings header, content, address section, instructions textarea, and actions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/styles/condensed-view.css Adds condensed-mode overrides targeting newly introduced shipping-settings-* data-slot hooks.
src/components/ServiceShippingSettings/ServiceShippingSettings.tsx Introduces data-slot hooks on the card and key sections to enable condensed-mode styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/ServiceShippingSettings/ServiceShippingSettings.tsx
Comment thread src/styles/condensed-view.css Outdated
Comment thread src/styles/condensed-view.css Outdated
@garrity-miepub garrity-miepub merged commit 157463b into main Apr 6, 2026
10 checks passed
@garrity-miepub garrity-miepub deleted the feature/condensed-view-service-shipping branch April 6, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants