fix(Pagination): make onPageChange optional in wrapper component types#25
Merged
garrity-miepub merged 1 commit intomainfrom Jan 28, 2026
Merged
fix(Pagination): make onPageChange optional in wrapper component types#25garrity-miepub merged 1 commit intomainfrom
garrity-miepub merged 1 commit intomainfrom
Conversation
The PaginationWithState and SimplePaginationWithState wrapper components
manage their own internal page state and provide onPageChange to the
underlying Pagination component. However, the wrapper's props type was
using React.ComponentProps<typeof Pagination> directly, which includes
onPageChange as a required prop.
This caused TypeScript errors in the showcase stories (AllVariants,
AllSizes) where the wrapper is used without passing onPageChange,
since the wrapper handles it internally.
Fix: Change the wrapper props type to:
Omit<React.ComponentProps<typeof Pagination>, 'onPageChange'> & {
onPageChange?: (page: number) => void;
}
This makes onPageChange optional for callers while still allowing them
to pass a callback if they want to be notified of page changes.
Deploying ui with
|
| Latest commit: |
b2cfc3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3415cc9.ui-6d0.pages.dev |
| Branch Preview URL: | https://bugfix-pagination-bug.ui-6d0.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PaginationWithState and SimplePaginationWithState wrapper components manage their own internal page state and provide onPageChange to the underlying Pagination component. However, the wrapper's props type was using React.ComponentProps directly, which includes onPageChange as a required prop.
This caused TypeScript errors in the showcase stories (AllVariants, AllSizes) where the wrapper is used without passing onPageChange, since the wrapper handles it internally.
Fix: Change the wrapper props type to:
Omit<React.ComponentProps, 'onPageChange'> & {
onPageChange?: (page: number) => void;
}
This makes onPageChange optional for callers while still allowing them to pass a callback if they want to be notified of page changes.