Skip to content

fix(Pagination): make onPageChange optional in wrapper component types #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garrity-miepub merged 1 commit into from
Jan 28, 2026
Merged

fix(Pagination): make onPageChange optional in wrapper component types #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/Pagination/Pagination.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ function PaginationWithState({
totalPages = 10,
onPageChange,
...props
}: React.ComponentProps<typeof Pagination>) {
}: Omit<React.ComponentProps<typeof Pagination>, 'onPageChange'> & {
onPageChange?: (page: number) => void;
}) {
const [page, setPage] = React.useState(initialPage);

const handlePageChange = (newPage: number) => {
Expand Down Expand Up @@ -168,7 +170,9 @@ function SimplePaginationWithState({
totalPages = 10,
onPageChange,
...props
}: React.ComponentProps<typeof SimplePagination>) {
}: Omit<React.ComponentProps<typeof SimplePagination>, 'onPageChange'> & {
onPageChange?: (page: number) => void;
}) {
const [page, setPage] = React.useState(initialPage);

const handlePageChange = (newPage: number) => {
Expand Down
Loading