fix(storybook): correct IconButton import path — manager build broken on main#339
Merged
Conversation
…oken on main PR #337 imported IconButton from 'storybook/components', which is not an export of the storybook package (v10 exposes it at storybook/internal/components). Every PR's CI has failed on the merge commit since. One-line path fix; manager build verified locally.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Storybook manager build by correcting the IconButton import path to match Storybook v10’s actual exports, unblocking CI for merge commits.
Changes:
- Update
.storybook/manager.tsto importIconButtonfromstorybook/internal/components(instead of the non-exportedstorybook/components).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#337 imported
IconButtonfromstorybook/components, which is not an export of thestorybookpackage — v10 exposes it atstorybook/internal/components. The manager build fails, so every PR's CI has been failing on its merge commit since (e.g. #336's run: https://github.com/mieweb/ui/actions/runs/30071361166).Fix
One-line import path correction.
storybook buildverified locally (manager + preview compile clean).Unblocks #336 and any other open PRs once merged.