Add Q as a UI component - #360
Open
aditya-damerla128 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new first-class Q surface to @mieweb/ui by wrapping the @mieweb/q agent config generator and exposing it via a dedicated @mieweb/ui/q entry point, plus presets and Storybook examples.
Changes:
- Add
Qwrapper component and presets (qAgentSchema,qTwilioAgentSchema, config factories). - Add
@mieweb/ui/qexport surface + tsup entry for a dedicated bundle boundary. - Add a local TypeScript shim for
@mieweb/qand wire in the@mieweb/qdependency.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsup.config.ts | Adds q and components/Q build entries; externalizes @mieweb/q. |
| src/q.ts | New @mieweb/ui/q entry re-exporting Q surface. |
| src/components/Q/Q.tsx | Adds Q wrapper around @mieweb/q’s AgentConfigGenerator. |
| src/components/Q/Q.stories.tsx | Adds Storybook examples for Q and presets. |
| src/components/Q/presets.ts | Adds Twilio + agent-only preset schemas and default configs. |
| src/components/Q/mieweb-q.d.ts | Adds local TS module declarations for @mieweb/q (+ /universal and css). |
| src/components/Q/index.ts | Defines the public re-export surface for @mieweb/ui/q. |
| package.json | Adds ./q export and introduces @mieweb/q as peer/dev dependency. |
| pnpm-lock.yaml | Locks @mieweb/q@1.0.0 and its dependency tree. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
pnpm-lock.yaml:7077
@mieweb/qpulls in@mieweb/ui@0.2.4pluslucide-react@0.344.0, whose peer range isreact: ^16.5.1 || ^17 || ^18(but this repo is on React 19). This can lead to peer-dependency warnings/failures in consumer installs (especially with strict peer deps) and potentially duplicate UI copies at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #359.
Adds Q as a UI component backed by
@mieweb/q, with a dedicated@mieweb/ui/qentry point so consumers can import Q directly from the UI package.Changes
Qcomponent wrapper around@mieweb/q'sAgentConfigGenerator.@mieweb/ui/qpackage export and tsup entry.@mieweb/qbecause the published package declares types but does not include the referenced.d.tsfile.Checks
pnpm run typecheckpnpm run lintpnpm run testpnpm run buildpnpm run formatgit diff --check -- package.json pnpm-lock.yaml tsup.config.ts src/q.ts src/components/Q/Q.tsx src/components/Q/Q.stories.tsx src/components/Q/index.ts src/components/Q/mieweb-q.d.ts src/components/Q/presets.tspnpm run build-storybook