fix(StepIndicator): render step circle above connector lines - #362
Merged
Conversation
Add relative z-10 to the step circle button so its ring is no longer overlapped by adjacent connector bars.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a layering issue in the horizontal StepIndicator where connector bars could visually overlap the active step’s circle/ring, by ensuring the step circle renders above the connector lines.
Changes:
- Add
relative z-10to the step circle button’s Tailwind class list to raise its stacking order above connector bars.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Deploying ui with
|
| Latest commit: |
cdabd6f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e36bbea.ui-6d0.pages.dev |
| Branch Preview URL: | https://bugfix-step-indicator-connec.ui-6d0.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the horizontal StepIndicator, the connector bars overlay the current step's circle — the ring around the active circle was being painted over by the adjacent connector lines.
Fix
Add
relative z-10to the step circle button so it (and its ring) renders above the connector bars.Verification
StepIndicator — Clickable All Steps)pnpm typecheck✅pnpm lint✅pnpm format:fix✅