✨ Update new resources split skeleton and patches

[aufi]

Updating plugin system creationg new resources to have better fit to crane transfor&apply structure. Returning structure better handled by crane code to prepare skeleton resources (type and name) to new/ stage directory and set of patches to be applied on thise skeletons during apply step.

Related to migtools/crane#728

Summary by CodeRabbit

• New Features

  • Added support for splitting generated Kubernetes resources into a minimal resource skeleton and an RFC 6902 JSON patch.
  • Preserves essential resource identity details, including API version, kind, name, and namespace.
  • Supports namespaced, cluster-scoped, and complex resources.

• Bug Fixes

  • Added validation and error handling for empty resources and invalid patch processing.

• Tests

  • Added comprehensive coverage for resource splitting, patch application, nested specifications, and error scenarios.

[coderabbitai]

Warning

Review limit reached

@aufi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d26e0e7-f3cf-4172-bcbd-d7ec5d31caa3

📥 Commits

Reviewing files that changed from the base of the PR and between 1f458d7 and d5154c7.

📒 Files selected for processing (2)

• transform/new_resource.go
• transform/new_resource_test.go

📝 Walkthrough

Walkthrough

Adds a function that splits a plugin-generated Kubernetes resource into a minimal skeleton and an RFC 6902 JSON patch. The implementation preserves identity metadata, sorts patch operations, escapes JSON Pointer paths, and validates common resource shapes.

Changes

New resource splitting

Layer / File(s)	Summary
Skeleton contract transform/new_resource.go	Adds NewResourceAnnotation and builds skeletons containing apiVersion, kind, and metadata name/namespace.
Deterministic patch generation transform/new_resource.go	Converts remaining metadata and top-level fields into sorted RFC 6902 add operations with RFC 6901 path escaping.
Behavior validation transform/new_resource_test.go	Tests namespaced, cluster-scoped, identity-only, nil, and nested resources, including successful patch round trips.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

• migtools/crane#415 — Directly covers new-resource skeleton and patch generation for plugin-produced Kubernetes resources.

Possibly related PRs

• migtools/crane-lib#135 — Adds related Kustomize patch serialization and multistage transform types.
• migtools/crane-lib#140 — Aggregates new resources that this change splits into skeletons and JSON patches.

Suggested reviewers: stillalearner

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the change to split new resources into skeletons and patches.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@transform/new_resource_test.go`:
- Line 176: Check and assert the error returned by json.Unmarshal at the first
site before inspecting result, and likewise handle the error from
result.UnmarshalJSON at the second site. Ensure unmarshaling failures terminate
the test with the underlying error before subsequent result assertions run.

In `@transform/new_resource.go`:
- Around line 132-151: Replace the hand-rolled replaceAll implementation with
the standard library’s strings.ReplaceAll, preserving the existing
escapeJSONPointer call order so "~" is still escaped before "/". Update the
imports accordingly and retain the replaceAll helper’s current behavior for
arbitrary UTF-8 input.
- Around line 12-14: The doc comment for the NewResourceAnnotation constant
claims the crane CLI writer routes resources to a new/ subdirectory, but this
routing behavior does not exist in the codebase. Remove the inaccurate claim
about CLI routing from the comment block above NewResourceAnnotation, and either
leave only the annotation's purpose or rewrite it to accurately reflect actual
usage of this constant in the repository.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e4cd9b70-357e-4487-a6b1-28f24107895d

📥 Commits

Reviewing files that changed from the base of the PR and between 8c6ef32 and 1f458d7.

📒 Files selected for processing (2)

• transform/new_resource.go
• transform/new_resource_test.go

[aufi]

We might discuss this approach if needed, but this should have better fit to crane transform&apply flow and not add an additional complexity to plugins.

[aufi]

/rfr

[stillalearner]

LGTM