🌱 Remove defunct --ignored-patches-dir flag from transform command

[Tamar-Dinavetsky]

Summary

Removes the --ignored-patches-dir flag from the transform command - the flag is no longer functional or
needed.

• Remove IgnoredPatchesDir field from Flags struct and flag registration in cmd/transform/transform.go
• Remove IgnoredPatchesDir field, GetIgnoredPatchesPath, and updateIgnoredPatchesDirPath from
  internal/file/file_helper.go
• Remove IgnoredPatchesDir field and args injection from e2e-tests/framework/crane.go

No existing tests referenced this flag.
#666

Summary by CodeRabbit

• Breaking Changes

  • Removed support for the --ignored-patches-dir option from the transform command.
  • Previously ignored or discarded patch outputs can no longer be written to a configured directory.

• New Features

  • Added support for configuring a plugin directory with the --plugin-dir option.

[coderabbitai]

📝 Walkthrough

Walkthrough

The transform command removes ignored-patch directory configuration. End-to-end transform options now support plugin directories, and file path helpers remove ignored-patch path generation while retaining transform-directory path rewriting.

Changes

Ignored-patch configuration cleanup

Layer / File(s)	Summary
Remove obsolete option surfaces cmd/transform/transform.go, e2e-tests/framework/crane.go, internal/file/file_helper.go	The command flags, transform options, and path options no longer expose IgnoredPatchesDir.
Update transform wiring and path helpers e2e-tests/framework/crane.go, internal/file/file_helper.go	The end-to-end runner emits --plugin-dir when configured, while file helpers remove ignored-patch path generation and retain transform-directory rewriting.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• [transform] Clean up and remove unused '--ignored-patches-dir' flag #666 — Directly covers removal of the obsolete --ignored-patches-dir flag and associated configuration.

Possibly related PRs

• migtools/crane#211 — Removes the same ignored-patch directory and path-helper plumbing as part of stage-scoped output handling.
• migtools/crane#555 — Also removes ignored-patch path/report helper support in internal/file/file_helper.go.

Suggested reviewers: stillalearner, msajidmansoori12

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: removing the defunct --ignored-patches-dir flag from the transform command.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Tamar-Dinavetsky]

/rfr

[midays]

LGTM

[Tamar-Dinavetsky]

[review-docs]

[Tamar-Dinavetsky]

📚 Documentation Review

Analyzed PR: #683
Latest commit: a292fc9

✅ No documentation updates needed - all docs are up to date!