OADP-7565: Go 1.25.8 toolchain + golang.org/x/* CVE bumps#165
OADP-7565: Go 1.25.8 toolchain + golang.org/x/* CVE bumps#165
Conversation
- Add toolchain go1.25.8 (fixes GO-2026-4337, GO-2026-4340, GO-2026-4341, GO-2026-4342, CVE-2026-25679, CVE-2026-27137) - golang.org/x/net v0.38.0 → v0.52.0 (fixes GHSA-vvgc-356p-c3xw) - golang.org/x/sys v0.35.0 → v0.42.0 - golang.org/x/text v0.23.0 → v0.35.0 - golang.org/x/term v0.30.0 → v0.41.0 - golang.org/x/mod v0.22.0 → v0.33.0 Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
- lint.yml: Replace hardcoded go-version '1.25' with go-version-file: 'go.mod' - test.yml: Replace hardcoded go-version '1.24' with go-version-file: 'go.mod' and bump actions/setup-go@v4 → @v6 (supports toolchain directive) Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
|
@kaovilai: This pull request references OADP-7565 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the project’s Go toolchain and golang.org/x/* dependencies to address reported CVEs, and aligns GitHub Actions workflows to use the Go version specified in go.mod (including the toolchain directive).
Changes:
- Adds/uses
toolchain go1.25.8ingo.modand bumpsgolang.org/x/net(and related transitivex/*) to newer patched versions. - Updates CI workflows to use
go-version-file: 'go.mod'instead of hardcoding Go versions. - Updates the test workflow to use
actions/setup-go@v6(toolchain-aware).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/test.yml |
Switches to actions/setup-go@v6 and reads Go version from go.mod via go-version-file. |
.github/workflows/lint.yml |
Reads Go version from go.mod via go-version-file for consistency with the toolchain directive. |
go.mod |
Declares toolchain go1.25.8 and updates golang.org/x/* versions to patched releases. |
go.sum |
Refreshes module sums consistent with the dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Closed in favor of #168. Prior PRs were pushed directly to Note Responses generated with Claude |
Summary
toolchain go1.25.8directive to fix Go stdlib CVEs:golang.org/x/netv0.38.0 → v0.52.0 (fixes GHSA-vvgc-356p-c3xw, XSS in HTML tokenizer)x/sys→ v0.42.0,x/text→ v0.35.0,x/term→ v0.41.0,x/mod→ v0.33.0go-version-file: 'go.mod'instead of hardcoded versionstest.yml: bumpedactions/setup-go@v4→@v6(supports toolchain directive)Note
golang.org/x/cryptois not in this module's dependency graph — those CVEs do not apply here.Supersedes #160
Test plan
go build ./...passesNote
Responses generated with Claude