OADP-7565: Use go-version-file in CI workflows#168
OADP-7565: Use go-version-file in CI workflows#168kaovilai wants to merge 1 commit intomigtools:oadp-1.6from
Conversation
- lint.yml: Replace hardcoded go-version '1.25' with go-version-file: 'go.mod' - test.yml: Replace hardcoded go-version '1.24' with go-version-file: 'go.mod' and bump actions/setup-go@v4 → @v6 (supports toolchain directive) Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
|
@kaovilai: This pull request references OADP-7565 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates CI workflows to derive the Go version/toolchain from go.mod (including the toolchain directive) instead of hardcoding Go versions in workflow files.
Changes:
- Switch
test.ymltogo-version-file: 'go.mod'and upgradeactions/setup-gofrom@v4to@v6. - Switch
lint.ymlfrom a hardcodedgo-versiontogo-version-file: 'go.mod'.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test.yml | Uses go.mod as the source of truth for Go version/toolchain; upgrades setup-go to v6. |
| .github/workflows/lint.yml | Uses go.mod as the source of truth for Go version/toolchain. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
go-version-file: 'go.mod'instead of hardcoded versionslint.yml: Replace hardcodedgo-version: '1.25'withgo-version-file: 'go.mod'test.yml: Replace hardcodedgo-version: '1.24'withgo-version-file: 'go.mod'and bumpactions/setup-go@v4→@v6(supports toolchain directive)Note
Go toolchain and
golang.org/x/*CVE bumps were already applied to oadp-1.6 in a prior merge.Supersedes #165
Test plan
Note
Responses generated with Claude