Skip to content

OADP-7565: Use go-version-file in CI workflows#168

Open
kaovilai wants to merge 1 commit intomigtools:oadp-1.6from
kaovilai:cve-fix-oadp-1.6
Open

OADP-7565: Use go-version-file in CI workflows#168
kaovilai wants to merge 1 commit intomigtools:oadp-1.6from
kaovilai:cve-fix-oadp-1.6

Conversation

@kaovilai
Copy link
Member

Summary

  • CI workflows updated to use go-version-file: 'go.mod' instead of hardcoded versions
    • lint.yml: Replace hardcoded go-version: '1.25' with go-version-file: 'go.mod'
    • test.yml: Replace hardcoded go-version: '1.24' with go-version-file: 'go.mod' and bump actions/setup-go@v4@v6 (supports toolchain directive)

Note

Go toolchain and golang.org/x/* CVE bumps were already applied to oadp-1.6 in a prior merge.

Supersedes #165

Test plan

  • CI passes

Note

Responses generated with Claude

- lint.yml: Replace hardcoded go-version '1.25' with go-version-file: 'go.mod'
- test.yml: Replace hardcoded go-version '1.24' with go-version-file: 'go.mod'
  and bump actions/setup-go@v4 → @v6 (supports toolchain directive)

Generated with [Claude Code](https://claude.ai/code)
via [Happy](https://happy.engineering)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Happy <yesreply@happy.engineering>
Copilot AI review requested due to automatic review settings March 24, 2026 17:56
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2026

@kaovilai: This pull request references OADP-7565 which is a valid jira issue.

Details

In response to this:

Summary

  • CI workflows updated to use go-version-file: 'go.mod' instead of hardcoded versions
  • lint.yml: Replace hardcoded go-version: '1.25' with go-version-file: 'go.mod'
  • test.yml: Replace hardcoded go-version: '1.24' with go-version-file: 'go.mod' and bump actions/setup-go@v4@v6 (supports toolchain directive)

[!Note]
Go toolchain and golang.org/x/* CVE bumps were already applied to oadp-1.6 in a prior merge.

Supersedes #165

Test plan

  • CI passes

[!Note]
Responses generated with Claude

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Joeavaikath and sseago March 24, 2026 17:56
@coderabbitai
Copy link

coderabbitai bot commented Mar 24, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f7f573c8-cbc5-4777-9b72-54072880e39f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI workflows to derive the Go version/toolchain from go.mod (including the toolchain directive) instead of hardcoding Go versions in workflow files.

Changes:

  • Switch test.yml to go-version-file: 'go.mod' and upgrade actions/setup-go from @v4 to @v6.
  • Switch lint.yml from a hardcoded go-version to go-version-file: 'go.mod'.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yml Uses go.mod as the source of truth for Go version/toolchain; upgrades setup-go to v6.
.github/workflows/lint.yml Uses go.mod as the source of truth for Go version/toolchain.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, kaovilai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Joeavaikath,kaovilai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants