update all trackers progress when new tracker is added#1372
Closed
cuong-tran wants to merge 5 commits intomihonapp:mainfrom
Closed
update all trackers progress when new tracker is added#1372cuong-tran wants to merge 5 commits intomihonapp:mainfrom
cuong-tran wants to merge 5 commits intomihonapp:mainfrom
Conversation
cuong-tran
force-pushed
the
update-all-trackers
branch
from
a01b434 to
5ae9618
Compare
Member
|
what's the reasoning? |
Contributor
Author
|
for example, if user has 2 trackers but with different progress, when user adds the 2nd tracker with a higher progress, this will sync all trackers to that higher progress instead of waiting for the next sync. Also, there is the TODO put right there state that. |
cuong-tran
force-pushed
the
update-all-trackers
branch
from
5ae9618 to
645f0ed
Compare
AntsyLich
requested changes
Feb 23, 2025
Member
AntsyLich
left a comment
AntsyLich
left a comment
There was a problem hiding this comment.
Apply the suggestion to the rest of the changes and add changelog
| } | ||
|
|
||
| syncChapterProgressWithTrack.await(mangaId, track, tracker) | ||
| val context = Injekt.get<Application>() |
Comment on lines
+82
to
+83
| .filter { it.first != null } | ||
| .forEach { (track, e) -> |
Member
There was a problem hiding this comment.
Suggested change
| .filter { it.first != null } | |
| .forEach { (track, e) -> | |
| .forEach { (track, e) -> | |
| if (track == null) return@forEach |
Comment on lines
+88
to
+94
| context.toast( | ||
| context.stringResource( | ||
| MR.strings.track_error, | ||
| track!!.name, | ||
| e.message ?: "", | ||
| ), | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| context.toast( | |
| context.stringResource( | |
| MR.strings.track_error, | |
| track!!.name, | |
| e.message ?: "", | |
| ), | |
| ) | |
| context.toast(context.stringResource(MR.strings.track_error, track.name, e.message ?: "")) |
Contributor
|
Will it prompt the user? It should, there's the snackbar from "Update on manually mark as read" already, so could call that |
Contributor
Author
|
This is wrong. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a new tracker is add, it will try to sync all trackers together with local reading progress