Skip to content

fix: download job stops all together even if 1 entry is failed to create directory#1445

Closed
cuong-tran wants to merge 12 commits intomihonapp:mainfrom
cuong-tran:adblock-webview
Closed

fix: download job stops all together even if 1 entry is failed to create directory#1445
cuong-tran wants to merge 12 commits intomihonapp:mainfrom
cuong-tran:adblock-webview

Conversation

@cuong-tran
Copy link
Contributor

@cuong-tran cuong-tran commented Nov 5, 2024

Also, when some entry failed to create download folder, it was showing a notification saying only "invalid location: /downloads" which is misleading.

This PR would:

  • If Download folder missing or no permission allowed, it will still stop the whole Downloader & show notification: "Invalid download directory or No permission allowed"
  • If only failed to create folder for 1 manga, it will skip that one, showing notification: "Invalid location: [source_dir/manga_dir]" and still continue other downloading

@cuong-tran cuong-tran changed the title more detail notification on invalid download location fix: download job stops all together even if 1 entry is failed to create directory Nov 5, 2024
Copy link
Member

@AntsyLich AntsyLich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And changelog

@cuong-tran cuong-tran marked this pull request as draft February 25, 2025 19:00
@cuong-tran cuong-tran marked this pull request as ready for review February 25, 2025 19:29
@cuong-tran cuong-tran marked this pull request as draft March 2, 2025 18:13
@cuong-tran cuong-tran marked this pull request as ready for review March 2, 2025 18:21
@AntsyLich
Copy link
Member

Superseded by #2068

@AntsyLich AntsyLich closed this May 4, 2025
@cuong-tran cuong-tran deleted the adblock-webview branch May 7, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants