add multiple selection mode on browse source#1670
add multiple selection mode on browse source#1670L-oung wants to merge 9 commits intomihonapp:mainfrom L-oung:main
Conversation
|
What is this for? |
Batch add manga from sources |
But you can already add several of them individually? Just long press on an entry and it'll add it to your default category/show the category selection screen. This new feature doesn't seem worth it in that respect. Edit: And even if the long press option didn't exist, you can still open the entry with a tap, then favourite it, then tap back and continue through the source's listings. |
Adding manga in large quantities is annoying:( |
|
And the process of adding manga will become slower and slower. I dont know why |
|
The last commit should go to a different PR, perhap? |
|
It sure doesn't look related to this PR 🤔 |
corner size book padding prefetch distance fetch items Ui modified
|
Why is there entirely different feature changes in this PR? |
# Conflicts: # app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreen.kt # app/src/main/java/eu/kanade/tachiyomi/ui/browse/source/browse/BrowseSourceScreenModel.kt # data/src/main/java/tachiyomi/data/source/SourcePagingSource.kt # data/src/main/sqldelight/tachiyomi/migrations/4.sqm # i18n/src/commonMain/moko-resources/base/strings.xml
|
Are you just pushing your personal flavour changes onto the same branch you used to make the PR? At this point, the PR is basically unusable with all its different unrelated changes. Either clean up your branch to whittle it down to the actual feature you meant to implement or close the PR for good. |
4 participants
No description provided.