Skip to content

Reset manga date when removed from library#1850

Closed
cuong-tran wants to merge 1 commit intomihonapp:mainfrom
cuong-tran:reset-manga-date
Closed

Reset manga date when removed from library#1850
cuong-tran wants to merge 1 commit intomihonapp:mainfrom
cuong-tran:reset-manga-date

Conversation

@cuong-tran
Copy link
Contributor

No description provided.

@BrutuZ
Copy link
Contributor

BrutuZ commented Mar 10, 2025

Isn't it already removed? I know I've had to restore backups a couple of times to fix old entries having their dateAdded updated after accidentally tapping the In Library button then adding them back

@cuong-tran
Copy link
Contributor Author

Isn't it already removed? I know I've had to restore backups a couple of times to fix old entries having their dateAdded updated after accidentally tapping the In Library button then adding them back

it only mark favorite = false, not actually removed from database.

@cuong-tran
Copy link
Contributor Author

I'm not sure if this matters, because when adding entry back to library, it will update new time, while the un-favorited entry in database doesn't really matter anywhere. It's just every other unfavorite action is reseting dateAdded to 0, except this one.

@BrutuZ
Copy link
Contributor

BrutuZ commented Mar 10, 2025

Is it really an issue since it gets overwritten anyway if added back?

@BrutuZ
Copy link
Contributor

BrutuZ commented Mar 10, 2025

Personally, I'd be more interested in it not updating dates when adding back. But I'm aware that would just suit my OCD and also break a workaround used by some to manually sort their libraries, so no point in opening a request

@cuong-tran
Copy link
Contributor Author

Agree. This only tried to make every place consistent.

@AntsyLich
Copy link
Member

I think it's fine as is

@AntsyLich AntsyLich closed this Apr 2, 2025
@cuong-tran cuong-tran deleted the reset-manga-date branch April 3, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants