Scribe 2.3.8 - Bug Fix: Don't make LLM provider request if there is no transcript
Fix: Skip LLM processing when transcription is disabled (#104)
Fixes #104
Problem
The "Transcribe recordings" and "Process transcriptions with LLM" settings were fully independent. With transcription off and processing on, handleTranscription() returned an empty string and the pipeline sent it straight to the LLM — resulting in a pointless (and paid) LLM call that generated garbage note sections.
Changes
- Settings UI (
src/settings/GeneralSettingsTab.tsx): "Process transcriptions with LLM" is now disabled and displayed as off while "Transcribe recordings" is off. The stored preference is left untouched, so re-enabling transcription restores the previous processing state. Description updated to note the dependency. - Toggle component (
src/settings/components/SettingsControl.tsx):SettingsTogglenow supports adisabledprop (click and Enter-key handlers are guarded). - Pipeline guard (
src/index.ts,handleScribeFile): if the transcript is empty, LLM summarization is skipped with aScribe: ⚠️ Skipping LLM processing — transcript is emptynotice. This covers stale persisted settings, the modal inheriting the disabled-transcription flag, and any provider legitimately returning an empty transcript.
Testing
npm run format:write,npm run lint:write,npm run build:prodall pass- Manual: with "Transcribe recordings" off, the processing toggle is off/unclickable; completing a recording shows the skip notice instead of calling the LLM. Re-enabling transcription restores the previous processing preference.
What's Changed
- Bug Fix: Don't make LLM provider request if there is no transcript by @Mikodin in #110
Full Changelog: 2.3.7...2.3.8