fix(read): spell the memo-key NUL delimiters as \x00 escapes - #381
Merged
Conversation
…scapes The ref-promoter memo key used raw 0x00 bytes as composite-key delimiters, which is behaviorally fine but makes grep and other text tools treat queries.ts as a binary file. Same delimiter, now spelled as an escape. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYbJensXxHpJK1v1VDXYUD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #362 ref-promoter memo key embedded two literal 0x00 bytes as composite-key delimiters. Behaviorally identical, but raw NULs make grep (and friends) classify
src/read/queries.tsas binary. Spelled as\x00escapes instead — same delimiter, clean text file. Found during the #368 rebase.🤖 Generated with Claude Code
https://claude.ai/code/session_01RYbJensXxHpJK1v1VDXYUD