pool: preserve results after the last error in WithErrors() (fixes #156) - #1
Open
milian256 wants to merge 1 commit into
Open
pool: preserve results after the last error in WithErrors() (fixes #156)#1milian256 wants to merge 1 commit into
milian256 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resultAggregator.collect() only appended the gaps between errored indices when filtering out errored results, never the tail after the last errored index -- so trailing non-errored results were silently dropped.
Example: three tasks returning 1, 2 (errored), 3 -- Wait() returned [1] instead of [1 3].
Fixes sourcegraph#156.
Adds a regression test reproducing the issue exactly.
Generated end-to-end by Terrarium (build -> aider fix -> go test verify -> independent reviewer approval) as a real integration test against an unseen open-source bug.