feat(quota): add Feature to ResourceRegistration type enum#594
Merged
Conversation
Add `Feature` as a valid value for `spec.type` on ResourceRegistration. Feature is a boolean entitlement grant used for org-level feature flags — no admission enforcement or claim machinery is involved. Regenerate CRD YAML and add a Chainsaw test step to verify type=Feature is accepted and reaches Active=True. Closes #575
This comment has been minimized.
This comment has been minimized.
## ✨ Autofixed 2 outdated doc(s) This pull was automatically generated by Joggr to fix 2 outdated doc(s) due to code changes in pull #594 ### Fixed docs The following docs were fixed: - `docs/api/quota.md`: The documentation was outdated because it omitted the newly-added 'Feature' type for resource registration, which is now a valid registration type with unique semantics. All locations describing valid types, measurement types, or the table entry were updated to include a clear explanation of Feature and its behavior. - `test/quota/registration-validation/README.md`: Documentation is outdated because a significant validation scenario—the creation and validation of a 'Feature' type ResourceRegistration—was added to tests and type enums but was not reflected in the test case matrix or steps in the README. I've inserted this missing scenario in both the test listing and detailed test description sections. ### How to fix To fix the docs, you can either: 1. Merge this pull request into your pull request to fix the docs 2. Wait for your pull request to be merged and then merge this pull request into your base branch --- Powered by [Joggr](https://joggr.ai?utm_source=gh&utm_medium=gh&utm_campaign=ghapr&utm_id=ghapr) - The documentation assistant for your codebase.
|
|
🤖 Automatically added newlines to 1 file(s) Co-Authored-By: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Contributor
|
🤖 I automatically added missing newlines at the end of 1 file(s) in this PR. All files should now end with a newline character as per coding standards. |
scotwells
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Featureas a valid value forspec.typeonResourceRegistration, alongside the existingEntityandAllocationvaluesFeatureis a boolean entitlement grant for org-level feature flags — no admission enforcement or claim machinery is used; the registration simply signals that a feature is available to an organizationquota.miloapis.com_resourceregistrations.yaml) so the new enum value is enforced at the API levelcreate-valid-feature-registration) to verify thattype=Featureis accepted and the registration reachesActive=TrueNo controller logic branches on
spec.type— grep confirms zero usages ofregistration.Spec.Typeininternal/quota/. This is a schema/validation-only change. The field is immutable after creation (CEL rule already in place).Closes #575
Related: datum-cloud/enhancements#695
Test plan
task generate:coderuns cleanly andFeatureappears inconfig/crd/bases/quota/quota.miloapis.com_resourceregistrations.yamlenumcreate-valid-feature-registrationpasses: creates aResourceRegistrationwithtype: Featureand waits forActive=Truetest-invalid-type-enum, immutability tests, etc.) continue to passspec.type