-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix: In the RunAnalyzer request, withDetail and withHash were not being passed
#41972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @sangheee! It looks like this is your first PR to milvus-io/milvus 🎉 |
|
@sangheee Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
@sangheee Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
|
@sangheee E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (73.10%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #41972 +/- ##
==========================================
+ Coverage 72.77% 73.10% +0.33%
==========================================
Files 341 335 -6
Lines 31946 30724 -1222
==========================================
- Hits 23249 22462 -787
+ Misses 8697 8262 -435
🚀 New features to boost your workflow:
|
|
@sangheee Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
@sangheee E2e jenkins job failed, comment |
…ng passed Signed-off-by: park.sanghee <park.sanghee@navercorp.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sangheee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/reopen |
I was calling
RunAnalyzerof milvusclient and expected to see details of tokens in the result, but they weren't showing up.I found that the
withDetailandwithHashoptions were not properly passed in the request payload.This PR fixes the issue by ensuring both options are correctly passed in the
RunAnalyzerrequest.