Skip to content

Conversation

@sangheee
Copy link
Contributor

@sangheee sangheee commented May 21, 2025

I was calling RunAnalyzer of milvusclient and expected to see details of tokens in the result, but they weren't showing up.
I found that the withDetail and withHash options were not properly passed in the request payload.

This PR fixes the issue by ensuring both options are correctly passed in the RunAnalyzer request.

@sre-ci-robot
Copy link
Contributor

Welcome @sangheee! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 21, 2025
@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@sangheee Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. kind/bug Issues or changes related a bug labels May 21, 2025
@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@sangheee Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 21, 2025
@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@sangheee E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.10%. Comparing base (48dde2e) to head (33f6c72).
Report is 1 commits behind head on master.

Current head 33f6c72 differs from pull request most recent head cbe8a96

Please upload reports for the commit cbe8a96 to get more accurate results.

❌ Your project status has failed because the head coverage (73.10%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41972      +/-   ##
==========================================
+ Coverage   72.77%   73.10%   +0.33%     
==========================================
  Files         341      335       -6     
  Lines       31946    30724    -1222     
==========================================
- Hits        23249    22462     -787     
+ Misses       8697     8262     -435     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 73.10% <ø> (+0.33%) ⬆️
Go ∅ <ø> (∅)

see 130 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot sre-ci-robot added area/compilation size/XL Denotes a PR that changes 500-999 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels May 21, 2025
@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@sangheee Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels May 21, 2025
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels May 21, 2025
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 21, 2025
@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@sangheee E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

…ng passed

Signed-off-by: park.sanghee <park.sanghee@navercorp.com>
@stale
Copy link

stale bot commented Jun 21, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 21, 2025
@stale stale bot removed the stale indicates no udpates for 30 days label Jun 24, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sangheee

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sangheee
Copy link
Contributor Author

/reopen

@mergify mergify bot added the ci-passed label Jun 24, 2025
@sangheee sangheee closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/compilation ci-passed dco-passed DCO check passed. do-not-merge/missing-related-issue kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants