Skip to content

Conversation

@sunby
Copy link
Contributor

@sunby sunby commented May 22, 2025

issue: #42015

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 22, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 22, 2025
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.47%. Comparing base (8a85bc4) to head (0524497).
Report is 25 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #42016       +/-   ##
===========================================
+ Coverage   73.04%   80.47%    +7.43%     
===========================================
  Files         335     1536     +1201     
  Lines       30702   216563   +185861     
===========================================
+ Hits        22425   174280   +151855     
- Misses       8277    36014    +27737     
- Partials        0     6269     +6269     
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 73.08% <ø> (+0.04%) ⬆️
Go 81.93% <100.00%> (∅)
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 92.29% <100.00%> (ø)

... and 1207 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label May 22, 2025
@MrPresent-Han
Copy link
Contributor

/lgtm
please help cp 2.5

@zhengbuqian
Copy link
Collaborator

/approve

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, sunby, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e9c0756 into milvus-io:master May 26, 2025
20 checks passed
sunby added a commit to sunby/milvus that referenced this pull request May 26, 2025
issue: milvus-io#42015

Signed-off-by: sunby <sunbingyi1992@gmail.com>
sre-ci-robot pushed a commit that referenced this pull request May 29, 2025
issue: #42015
pr: #42016

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants