Skip to content

enhance: milvus support minhash vector and mhjaccard metric #42036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sre-ci-robot merged 1 commit into from
Jun 10, 2025
Merged

enhance: milvus support minhash vector and mhjaccard metric #42036

sre-ci-robot merged 1 commit into from
Jun 10, 2025

Conversation

@cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented May 23, 2025 •
edited
Loading

issue: #41746

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/compilation labels May 23, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 23, 2025
@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@codecov
Copy link

codecov bot commented May 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (80ac672) to head (dec75c1).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #42036      +/-   ##
==========================================
+ Coverage   80.54%   80.56%   +0.02%     
==========================================
  Files        1544     1544              
  Lines      219423   219392      -31     
==========================================
+ Hits       176736   176764      +28     
+ Misses      36331    36278      -53     
+ Partials     6356     6350       -6
Components Coverage Δ
Client 79.36% <ø> (ø)
Core 72.71% <100.00%> (-0.03%) ⬇️
Go 82.10% <100.00%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/common/Types.h 25.05% <100.00%> (+0.15%) ⬆️
internal/core/src/common/Utils.h 97.14% <100.00%> (+0.02%) ⬆️
internal/proxy/util.go 85.16% <100.00%> (ø)
pkg/util/metric/similarity_corelation.go 100.00% <100.00%> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

@cqy123456 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

cqy123456 commented Jun 3, 2025

/run-cpu-e2e

1 similar comment
@cqy123456
Copy link
Contributor Author

cqy123456 commented Jun 3, 2025

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Jun 3, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2025

@cqy123456 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@cqy123456
enhance: milvus support minhash vector and mhjaccard metric
dec75c1 
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2025

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

cqy123456 commented Jun 9, 2025

/run-cpu-e2e

1 similar comment
@cqy123456
Copy link
Contributor Author

cqy123456 commented Jun 9, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 9, 2025
foxspy
foxspy approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

czs007
czs007 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Jun 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 317bbfb into milvus-io:master Jun 10, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czs007 czs007 czs007 approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

+1 more reviewer

@foxspy foxspy foxspy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@foxspy foxspy

@czs007 czs007

Labels

approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cqy123456 @sre-ci-robot @foxspy @czs007