Error handling using failure in API#949
Merged
Merged
Conversation
This PR adresses mimblewimble#166 Error handling in wallet was ported to failure in mimblewimble#713 Using the same error model makes wallet code simpler and may simplify migration to Hyper.
Member
|
Think this looks fine, no reason to leave it outstanding. Thanks! |
dpc
pushed a commit
to dpc/grin
that referenced
this pull request
Oct 24, 2018
This PR adresses mimblewimble#166 Error handling in wallet was ported to failure in mimblewimble#713 Using the same error model makes wallet code simpler and may simplify migration to Hyper.
Makaric
pushed a commit
to Makaric/bitgrin
that referenced
this pull request
May 16, 2026
This PR adresses mimblewimble#166 Error handling in wallet was ported to failure in mimblewimble#713 Using the same error model makes wallet code simpler and may simplify migration to Hyper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #166
Error handling in wallet was ported to failure in #713
Using the same error model makes wallet code simpler and may simplify migration to Hyper.
try!with?