Skip to content

Added Site Themes toggle for #619#632

Closed
Pandawan wants to merge 2 commits into
minbrowser:masterfrom
Pandawan:site-themes
Closed

Added Site Themes toggle for #619#632
Pandawan wants to merge 2 commits into
minbrowser:masterfrom
Pandawan:site-themes

Conversation

@Pandawan

@Pandawan Pandawan commented Oct 2, 2018

Copy link
Copy Markdown
Contributor

So #619 asked for a simple toggle in the preferences to disable site colors (like when you go on Google and it changes tabs to blue or something).

This will require adding new translations for every language, I have only added for en_us for now.
Also it might conflict with other current PRs that are refactoring the tabColor module though it shouldn't be too hard to fix.

Another idea to make this better would be to allow for custom theming (where users can select from a variety of colors instead of a simple toggle), but this would be outside of the scope of the original issue.

@Nybbit

Nybbit commented Oct 2, 2018

Copy link
Copy Markdown

You can cut down on the code here and turn it into

settings.get('siteThemes', function(value) {
    window.allowSiteThemes = value
    window.dispatchEvent(new CustomEvent('themechange'))
});

@PalmerAL

PalmerAL commented Oct 2, 2018

Copy link
Copy Markdown
Collaborator

The code looks pretty good, but I'm wondering if this is something we want to do in the first place. A lot of the decisions about the UI (having everything be the same color and using opacity/weight/size to communicate things instead) were assuming that the background color would continually changing. If we assume that the background color is always the same, then we would probably want to design the rest of the UI differently as wel.

However, it does seem like this is something people want (aside from the linked issue, a couple of people have mentioned it in the survey as well), so I guess I'm OK with adding this if there's enough interest. At the same time, I'd like to understand why people don't like the effect. Is it just distracting? Are there certain sites where the color-selection algorithm doesn't work very well? Does it make the tab bar harder to see?

@Pandawan

Pandawan commented Oct 4, 2018

Copy link
Copy Markdown
Contributor Author

Hmmm, yeah that's understandable. I feel like some people just really like the aesthetics/simplicity of the pure white theme.

Also, there really isn't a need to redesign the UI, make it so that site themes are a default and that if people don't like it, they can always make it white. This would make it so that you keep designing under the assumption that people will use the site themes with varying background colors so that the UI works with any background (even a basic white color).

EDIT: This would also require making site themes true by default in the code.

@PalmerAL

PalmerAL commented Oct 5, 2018

Copy link
Copy Markdown
Collaborator

Yeah, I can see how it might be less distracting. Keeping everything monochrome is probably what we would do, I'm just not sure it looks very good - it seems very "empty". I think I'm going to wait and see if more people request this.

@PalmerAL

Copy link
Copy Markdown
Collaborator

There were more requests to add this in #790, so I went ahead and added this option in 8dbfdef (with a couple changes from this PR to account for the settings redesign in #766).

@PalmerAL PalmerAL closed this Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants