Skip to content

Conversation

@ixunio
Copy link
Contributor

@ixunio ixunio commented Jan 12, 2022

PR Details

The SDK is not able to parse the HTTP URLs when using on Windows. URLs generation is somehow using python os.path helpers that make path with "/" on Unix systems but "" on Windows.

Description

Rewrite URL generation from one single function
Fix Windows URL generation issue

How Has This Been Tested

This has not been tested properly, only on invoice API.

Types of changes

  • [ x ] Docs change / refactoring / dependency upgrade
  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ixunio ixunio requested a review from fharper January 12, 2022 14:40
Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fharper
Copy link
Contributor

fharper commented Jan 14, 2022

Was redone by @ianardee in #39

@fharper fharper closed this Jan 14, 2022
@fharper fharper deleted the better-url-management branch January 14, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants