Skip to content

Conversation

@ianardee
Copy link
Contributor

@ianardee ianardee commented Jan 14, 2022

Fix for URLs in Windows

Description

URLs are not system paths, don't use os.path to build them.

Related Issue

#33

Motivation and Context

Users could not use the library in Windows OS family.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@jonathanMindee jonathanMindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Way much cleaner for making the URL.

@fharper
Copy link
Contributor

fharper commented Jan 14, 2022

No need to review this PR as #40 has been created from this branch and not main I guess, it contains both PR.

I have a hook for branch creation about this if you want @ianardee: it prevent me from doing this without -n since I was always doing that :D

@fharper fharper closed this Jan 14, 2022
@ianardee ianardee reopened this Jan 15, 2022
@ianardee ianardee merged commit 01b99ec into main Jan 15, 2022
@ianardee ianardee deleted the fix-url-builder branch January 15, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants