Skip to content

Conversation

@ianardee
Copy link
Contributor

Add mypy and pylint

Description

Add mypy for type checking and pylint for static analysis.

Do some very basic improvements just to make sure everything works.

Motivation and Context

This will avoid bugs, hopefully!

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ianardee ianardee force-pushed the add-mypy-pylint branch 2 times, most recently from dac352e to a4fe042 Compare January 14, 2022 16:58
Copy link
Contributor

@fharper fharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fharper
Copy link
Contributor

fharper commented Jan 14, 2022

As discussed, I'll let you merge it @ianardee

@ianardee ianardee merged commit fae922c into main Jan 15, 2022
@ianardee ianardee deleted the add-mypy-pylint branch January 15, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants