Skip to content

♻️ uniformize with other sdks#448

Merged
sebastianMindee merged 4 commits into
mainfrom
uniformize-with-other-sdks
Jul 17, 2026
Merged

♻️ uniformize with other sdks#448
sebastianMindee merged 4 commits into
mainfrom
uniformize-with-other-sdks

Conversation

@sebastianMindee

Copy link
Copy Markdown
Collaborator

Description

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires a change to the official Guide documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to “uniformize” the Python SDK with other Mindee SDKs by adding typed accessors to SimpleField, introducing a polling cancellation mechanism in the V2 client, and strengthening URL input validation against common SSRF vectors.

Changes:

  • Added string_value / number_value / boolean_value convenience properties on SimpleField + unit tests.
  • Added a CancellationToken and optional cancellation_token support in Client.enqueue_and_get_result.
  • Replaced the URL scheme check with a more complete validate_url_for_source SSRF-focused validation.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/v2/parsing/test_simple_field.py Adds unit coverage for the new typed SimpleField accessors.
tests/v2/file_operations/test_split_operation_integration.py Removes a stray blank line in an integration test.
mindee/v2/parsing/inference/field/simple_field.py Introduces typed getters that validate the stored value’s type.
mindee/v2/client.py Adds optional cancellation token support during polling.
mindee/mindee_http/response_validation.py Adds validate_url_for_source for SSRF-oriented URL validation.
mindee/mindee_http/cancellation_token.py Introduces a small cancellation token class.
mindee/input/url_input_source.py Uses validate_url_for_source instead of a simple https prefix check.

Comment thread mindee/mindee_http/cancellation_token.py
Comment thread mindee/v2/client.py
Comment thread mindee/v2/client.py
Comment thread mindee/mindee_http/response_validation.py
@sebastianMindee
sebastianMindee force-pushed the uniformize-with-other-sdks branch 3 times, most recently from 3a8fd79 to a54e9dd Compare July 17, 2026 14:15
@sebastianMindee
sebastianMindee force-pushed the uniformize-with-other-sdks branch from a54e9dd to 540d1d8 Compare July 17, 2026 14:34
@sebastianMindee
sebastianMindee merged commit 9b9b048 into main Jul 17, 2026
42 checks passed
@sebastianMindee
sebastianMindee deleted the uniformize-with-other-sdks branch July 17, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants