Add Denodo integration handler by ritwickrajmakhal · Pull Request #10432 · mindsdb/minds

ritwickrajmakhal · 2025-01-31T18:29:42Z

Description

This pull request introduces the integration of MindsDB with Denodo, a data virtualization platform. The changes include adding documentation, defining connection parameters, and implementing the Denodo handler to manage database interactions.

Fixes: #10057

Type of change

⚡ New feature (non-breaking change which adds functionality)

Additional Media:

2025-01-31.23-49-56.mp4

I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

My code follows the style guidelines(PEP 8) of MindsDB.
I have appropriately commented on my code, especially in complex areas.
Necessary documentation updates are either made or tracked in issues.
Relevant unit and integration tests are updated or added.

ritwickrajmakhal · 2025-01-31T18:30:07Z

@quest-bot loot #10057

quest-bot · 2025-01-31T18:30:14Z

Quest PR submitted!

@ritwickrajmakhal, you are attempting to solve the issue and loot this Quest. Will you be successful?

Questions? Check out the docs.

ZoranPandovski

Thanks. The only question I have is the usage of mysql dialect and mentioning denodo dialect. I've never used Denodo it looks like they have their own VQL?

ritwickrajmakhal · 2025-02-18T17:10:24Z

Yes Denodo has their own VQL language, but also it suppports sql statements also.

martyna-mindsdb · 2025-07-14T12:42:37Z

@ritwickrajmakhal
Please fix the Test on Push so @ZoranPandovski can review it. Thanks.

ritwickrajmakhal · 2025-07-14T13:49:42Z

Done ✅

Co-authored-by: andrew <elkin.andr@gmail.com>

Co-authored-by: martyna-mindsdb <109554435+martyna-mindsdb@users.noreply.github.com>

entelligence-ai-pr-reviews · 2026-03-13T08:58:39Z

+    def get_columns(self, table_name: str) -> Response:
+        """
+        Get columns for specified table using parameterized query.
+        """


Correctness: table_name is directly interpolated into the SQL string despite the docstring claiming it's parameterized — this allows SQL injection via a crafted table name.

🤖 AI Agent Prompt for Cursor/Windsurf

📋 Copy this prompt to your AI coding assistant (Cursor, Windsurf, etc.) to get help fixing this issue

In mindsdb/integrations/handlers/denodo_handler/denodo_handler.py at line 148, the `get_columns` method builds a SQL string by directly interpolating `table_name` and `self.database` using an f-string. This allows SQL injection. Fix by using parameterized query execution (pass parameters separately to `cursor.execute`) instead of string interpolation.

entelligence-ai-pr-reviews · 2026-03-13T08:58:39Z

+            logger.error(f"Error connecting to Denodo: {str(e)}")
+            raise ConnectionError(f"Failed to connect to Denodo: {str(e)}")
+
+    def disconnect(self) -> None:


Duplicate Code: ⚠️ Duplicate Code Detected (Similarity: 90%)

This function disconnect duplicates existing code.

📍 Original Location:

mindsdb/integrations/handlers/postgres_handler/postgres_handler.py:211-218

Function: disconnect

💡 Recommendation:
Remove disconnect from DenodoHandler entirely by inheriting from PostgresHandler. If the psycopg2 vs psycopg3 driver difference requires a custom disconnect, keep a minimal override that only addresses the driver-specific teardown.

Consider importing and reusing the existing function instead of duplicating the logic.

StpMax · 2026-03-13T09:23:51Z

+- `user`: The username for the Denodo database.
+- `password`: The password for the Denodo database.
+- `host`: The hostname, IP address, or URL of the Denodo server.
+- `port`: The port number for connecting to the Denodo server (default is `9999`).


9999 or 9996 ?

StpMax · 2026-03-13T09:25:35Z

+                password=self.connection_data.get("password"),
+                database=self.connection_data.get("database"),
+            )
+            return self.connection


will be good to set self.is_connected=True

ritwickrajmakhal had a problem deploying to manual-approval January 31, 2025 18:29 — with GitHub Actions Error

quest-bot Bot added the ⚔️ Quest Tracks quest-bot quests label Jan 31, 2025

quest-bot Bot mentioned this pull request Jan 31, 2025

[Integration]: DENODO INTEGRATION #10057

Closed

1 task

quest-bot Bot had a problem deploying to manual-approval January 31, 2025 18:30 Error

ritwickrajmakhal had a problem deploying to manual-approval January 31, 2025 18:30 — with GitHub Actions Error

ritwickrajmakhal changed the title ~~Add Denodo integration handler and documentation~~ Add Denodo integration handler Jan 31, 2025

ritwickrajmakhal had a problem deploying to manual-approval February 10, 2025 04:39 — with GitHub Actions Error

ZoranPandovski requested changes Feb 18, 2025

View reviewed changes

ritwickrajmakhal had a problem deploying to manual-approval February 18, 2025 15:42 — with GitHub Actions Error

ritwickrajmakhal had a problem deploying to manual-approval February 18, 2025 17:10 — with GitHub Actions Failure

ritwickrajmakhal had a problem deploying to manual-approval April 2, 2025 19:27 — with GitHub Actions Error

ritwickrajmakhal had a problem deploying to manual-approval April 15, 2025 15:25 — with GitHub Actions Failure

ritwickrajmakhal added 2 commits May 16, 2025 00:16

Add Denodo integration handler and documentation

66f91cb

Change DenodoHandler dialect from 'denodo' to 'mysql'

777125f

ritwickrajmakhal force-pushed the denodo-integration branch from cd521a6 to 777125f Compare May 15, 2025 18:46

ritwickrajmakhal had a problem deploying to manual-approval May 15, 2025 18:46 — with GitHub Actions Failure

ritwickrajmakhal requested a review from ZoranPandovski May 15, 2025 18:46

ritwickrajmakhal had a problem deploying to manual-approval July 3, 2025 13:13 — with GitHub Actions Error

ritwickrajmakhal had a problem deploying to manual-approval July 14, 2025 13:21 — with GitHub Actions Error

martyna-mindsdb had a problem deploying to manual-approval July 14, 2025 14:02 — with GitHub Actions Failure

sejubar and others added 5 commits November 11, 2025 17:52

Fqe 1675 - additional test for mysql api (#11797)

8cbbe60

Co-authored-by: andrew <elkin.andr@gmail.com>

Update datastax.mdx (#11873)

1c7eb20

Fixed MSSQL Query Execution Result Conversion (#11876)

dba3869

Update documentation for ENV Variables (#11667)

01a6b37

Co-authored-by: martyna-mindsdb <109554435+martyna-mindsdb@users.noreply.github.com>

[BUG] - Hubspot Handler - CRUD operations (#11874)

a4bc712

Apply ruff formatting

09af05e

ritwickrajmakhal force-pushed the denodo-integration branch from 0165378 to 09af05e Compare November 13, 2025 13:15

ritwickrajmakhal changed the base branch from main to develop November 13, 2025 13:16

Merge branch 'develop' into denodo-integration

deee7f3

StpMax changed the base branch from develop to releases/26.1.0 March 13, 2026 08:49

Merge branch 'releases/26.1.0' into denodo-integration

344ecc9

entelligence-ai-pr-reviews Bot reviewed Mar 13, 2026

View reviewed changes

StpMax approved these changes Mar 13, 2026

View reviewed changes

StpMax merged commit eef5ad3 into mindsdb:releases/26.1.0 Mar 13, 2026
10 of 12 checks passed

github-actions Bot locked and limited conversation to collaborators Mar 13, 2026

ritwickrajmakhal deleted the denodo-integration branch March 13, 2026 16:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Denodo integration handler#10432

Add Denodo integration handler#10432
StpMax merged 10 commits into
mindsdb:releases/26.1.0from
ritwickrajmakhal:denodo-integration

ritwickrajmakhal commented Jan 31, 2025 •

edited

Loading

Uh oh!

ritwickrajmakhal commented Jan 31, 2025

Uh oh!

quest-bot Bot commented Jan 31, 2025

Uh oh!

ZoranPandovski left a comment

Uh oh!

ritwickrajmakhal commented Feb 18, 2025

Uh oh!

martyna-mindsdb commented Jul 14, 2025

Uh oh!

ritwickrajmakhal commented Jul 14, 2025

Uh oh!

entelligence-ai-pr-reviews Bot Mar 13, 2026

Uh oh!

entelligence-ai-pr-reviews Bot Mar 13, 2026

Uh oh!

StpMax Mar 13, 2026

Uh oh!

StpMax Mar 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

ritwickrajmakhal commented Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Additional Media:

Checklist:

Uh oh!

ritwickrajmakhal commented Jan 31, 2025

Uh oh!

quest-bot Bot commented Jan 31, 2025

Quest PR submitted!

Uh oh!

ZoranPandovski left a comment

Choose a reason for hiding this comment

Uh oh!

ritwickrajmakhal commented Feb 18, 2025

Uh oh!

martyna-mindsdb commented Jul 14, 2025

Uh oh!

ritwickrajmakhal commented Jul 14, 2025

Uh oh!

entelligence-ai-pr-reviews Bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

entelligence-ai-pr-reviews Bot Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

StpMax Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

StpMax Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ritwickrajmakhal commented Jan 31, 2025 •

edited

Loading