Skip to content

Add healthcheck to container#11981

Merged
hamishfagg merged 8 commits into
releases/26.1.0from
add/healthcheck
Mar 30, 2026
Merged

Add healthcheck to container#11981
hamishfagg merged 8 commits into
releases/26.1.0from
add/healthcheck

Conversation

@hamishfagg

Copy link
Copy Markdown
Contributor

Description

Please include a summary of the change and the issue it solves.

Fixes #issue_number

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@entelligence-ai-pr-reviews

Copy link
Copy Markdown
Contributor

Entelligence AI Vulnerability Scanner

Status: No security vulnerabilities found

Your code passed our comprehensive security analysis.

@martyna-mindsdb

Copy link
Copy Markdown
Contributor

@hamishfagg
What's the status here? Can this be closed/merged?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Docker container healthcheck for MindsDB so orchestrators (Docker, Compose, Kubernetes via Docker runtime) can detect when the service is unhealthy.

Changes:

  • Adds a HEALTHCHECK to docker/mindsdb.Dockerfile that polls http://localhost:47334/api/status.
  • Leaves the healthcheck inherited by downstream stages (dev and the final extras-based image).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docker/mindsdb.Dockerfile Outdated
Comment thread docker/mindsdb.Dockerfile Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@martyna-mindsdb

Copy link
Copy Markdown
Contributor

@hamishfagg @lucas-koontz
Can we retarget this PR to the releases/26.1.0 branch please?

@lucas-koontz lucas-koontz changed the base branch from main to releases/26.1.0 March 30, 2026 19:02
@lucas-koontz lucas-koontz requested a review from a team as a code owner March 30, 2026 19:02
@hamishfagg hamishfagg merged commit de757a9 into releases/26.1.0 Mar 30, 2026
17 checks passed
@hamishfagg hamishfagg deleted the add/healthcheck branch March 30, 2026 19:33
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants