Skip to content

Docs - BYOM fix predict example#12033

Merged
martyna-mindsdb merged 9 commits into
mindsdb:releases/26.1.0from
Raahim-Lone:docs/byom-fix-predict-example
Mar 26, 2026
Merged

Docs - BYOM fix predict example#12033
martyna-mindsdb merged 9 commits into
mindsdb:releases/26.1.0from
Raahim-Lone:docs/byom-fix-predict-example

Conversation

@Raahim-Lone

@Raahim-Lone Raahim-Lone commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

Description

This updates the BYOM docs example to avoid target leakage and clarifies that prediction inputs should not include the target column when joining for predictions. Primary testing should look at docs/integrations/ai-engines/byom.mdx.

Additional testing can start MindsDB locally, train a BYOM model on a small SQLite table using the updated example, and verify predictions work when the input query excludes the target column.

Fixes #11543

Documentation Update

(Please delete options that are not relevant)

  • 📄 This change requires a documentation update

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.

@github-actions

github-actions Bot commented Dec 21, 2025

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

# Conflicts:
#	docs/setup/environment-vars.mdx
#	mindsdb/integrations/handlers/hubspot_handler/hubspot_tables.py
@martyna-mindsdb martyna-mindsdb requested a review from ea-rus March 10, 2026 11:58
@ea-rus ea-rus changed the base branch from develop to releases/26.1.0 March 26, 2026 11:31
@ea-rus ea-rus changed the base branch from releases/26.1.0 to develop2 March 26, 2026 11:31
@ea-rus ea-rus changed the base branch from develop2 to releases/26.1.0 March 26, 2026 11:32
@martyna-mindsdb martyna-mindsdb merged commit cefcb6e into mindsdb:releases/26.1.0 Mar 26, 2026
9 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Give original target value as predicted result when using custom ML model

8 participants