Skip to content

Fix malformed BigQuery PK metadata SQL#12252

Merged
StpMax merged 1 commit into
mindsdb:releases/26.1.0from
ianu82:codex/fix-bigquery-pk-query-comma
Mar 19, 2026
Merged

Fix malformed BigQuery PK metadata SQL#12252
StpMax merged 1 commit into
mindsdb:releases/26.1.0from
ianu82:codex/fix-bigquery-pk-query-comma

Conversation

@ianu82

@ianu82 ianu82 commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the trailing comma from the meta_get_primary_keys SELECT list in the BigQuery handler
  • extend the unit test to assert the generated query does not include a dangling comma before FROM

Why

The trailing comma produces invalid SQL and breaks metadata introspection for primary keys.

Validation

  • python3 -m py_compile mindsdb/integrations/handlers/bigquery_handler/bigquery_handler.py tests/unit/handlers/test_bigquery.py
  • pytest -q tests/unit/handlers/test_bigquery.py -k meta_get_primary_keys_filters (fails in this environment due to missing optional dependency google.api_core)

@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ianu82

ianu82 commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@StpMax StpMax changed the base branch from main to releases/26.1.0 March 19, 2026 14:40
@StpMax StpMax merged commit 7068687 into mindsdb:releases/26.1.0 Mar 19, 2026
28 of 33 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants