Fix Snowflake FK metadata parent/child direction#12255
Merged
StpMax merged 1 commit intoMar 20, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
StpMax
approved these changes
Mar 20, 2026
StpMax
left a comment
Contributor
There was a problem hiding this comment.
I can't check it, but looks convincing.
Will be also good to change columns names in the test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meta_get_foreign_keyscolumn renaming so Snowflake PK columns map toparent_*and FK columns map tochild_*Why
SHOW IMPORTED KEYSreturns primary-key metadata inpk_*columns and foreign-key metadata infk_*columns. The previous rename inverted this relationship, producing reversed lineage in the catalog.Validation
python3 -m py_compile mindsdb/integrations/handlers/snowflake_handler/snowflake_handler.py tests/unit/handlers/test_snowflake.pypytest -q tests/unit/handlers/test_snowflake.py -k meta_get_foreign_keys_filters(fails in this environment due to missing optional dependencyappdirs)