Skip to content

Fix Databricks get_tables non-table response handling#12259

Merged
StpMax merged 1 commit into
mindsdb:releases/26.1.0from
ianu82:codex/fix-databricks-get-tables-nontable
Mar 20, 2026
Merged

Fix Databricks get_tables non-table response handling#12259
StpMax merged 1 commit into
mindsdb:releases/26.1.0from
ianu82:codex/fix-databricks-get-tables-nontable

Conversation

@ianu82

@ianu82 ianu82 commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a guard in Databricks get_tables() to return early for non-table responses or missing dataframes
  • only uppercase/rename columns when a table dataframe is present
  • add a regression unit test ensuring error responses pass through unchanged

Why

get_tables() previously assumed result.data_frame always existed. On error/non-table responses this triggered secondary exceptions and masked the original failure.

Validation

  • python3 -m py_compile mindsdb/integrations/handlers/databricks_handler/databricks_handler.py tests/unit/handlers/test_databricks.py
  • pytest -q tests/unit/handlers/test_databricks.py -k get_tables_returns_non_table_response_without_transform (fails in this environment due to missing optional dependency appdirs)

@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@ianu82

ianu82 commented Feb 27, 2026

Copy link
Copy Markdown
Contributor Author

review

@StpMax StpMax changed the base branch from main to releases/26.1.0 March 20, 2026 12:07
@StpMax StpMax merged commit a05f479 into mindsdb:releases/26.1.0 Mar 20, 2026
11 of 14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants