fix: correct isinstance check for redirect_url in database endpoints#12279
Merged
StpMax merged 1 commit intoMar 24, 2026
Merged
Conversation
… status The condition `isinstance(status, str)` always evaluates to False because `status` is a HandlerStatusResponse instance, never a str. This makes the redirect_url handling dead code. The intent was to check whether `status.redirect_url` is a string. This bug appears in both the POST /databases and POST /databases/status endpoints. Signed-off-by: JiangNan <1394485448@qq.com>
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
@jnMetaCode please, leave a comment as described above |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
StpMax
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in where is used instead of .
is always a instance, so always evaluates to . This makes the redirect URL handling completely unreachable in both the and endpoints.
The fix changes to in both locations, which matches the original intent of checking whether the attribute contains a string value before returning the redirect response.
Test plan