Skip to content

Fix upload xlsx files#12306

Merged
ea-rus merged 5 commits into
releases/26.1.0from
fix-upload-xlsx
Mar 23, 2026
Merged

Fix upload xlsx files#12306
ea-rus merged 5 commits into
releases/26.1.0from
fix-upload-xlsx

Conversation

@ea-rus

@ea-rus ea-rus commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Description

Close file descriptor explicitly

Fixes https://linear.app/mindsdb/issue/FQE-2130/test-suport-for-xls-files

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@sejubar sejubar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
was able to upload xlsx file with no permission issue.

@ea-rus ea-rus merged commit b0f2729 into releases/26.1.0 Mar 23, 2026
18 checks passed
@ea-rus ea-rus deleted the fix-upload-xlsx branch March 23, 2026 15:04
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants