Fix subquery references #12337
Merged
Merged
Conversation
ea-rus
approved these changes
Mar 31, 2026
| ) | ||
| b = pd.DataFrame([{"shop": 1}, {"shop": 2}, {"shop": 3}]) | ||
|
|
||
| result = query_dfs( |
Contributor
There was a problem hiding this comment.
the query is almost the same as in test_multi_table_relational_division
maybe we can reuse that test?
Contributor
Author
There was a problem hiding this comment.
They are similar, but not exactly the same. I think it would be better to separate them than to link the files with additional imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix correlated subquery references being stripped in query_dfs
adapt_queryinquery_dfswas stripping all multi-part identifiers to just the column name (a1.tab_num→tab_num), which broke correlated subqueries. For example,WHERE a2.tab_num = a1.tab_numbecameWHERE tab_num = tab_num— that made NOT EXISTS and EXISTS produce identical results.The fix collects the actual schema/database names from the FROM clause before traversal, and only strips identifiers whose first part matches a known schema — leaving table alias references (
a1.col,b.shop) intact for DuckDB to resolve correctly.Fixes #11763 FQE-1690
Type of change
(Please delete options that are not relevant)
Verification Process
To ensure the changes are working as expected:
Additional Media:
Checklist: