Skip to content

Fix: Check all annotations for targets in LocalArgsOnlyInspection. #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Fix: Check all annotations for targets in LocalArgsOnlyInspection. #2529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/kotlin/platform/mixin/inspection/mixinextras/LocalArgsOnlyInspection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import com.demonwav.mcdev.platform.mixin.util.MixinConstants
import com.demonwav.mcdev.platform.mixin.util.MixinConstants.MixinExtras.unwrapLocalRef
import com.demonwav.mcdev.util.constantValue
import com.demonwav.mcdev.util.findContainingMethod
import com.demonwav.mcdev.util.mapFirstNotNull
import com.demonwav.mcdev.util.ifEmpty
import com.intellij.codeInspection.ProblemsHolder
import com.intellij.psi.JavaElementVisitor
import com.intellij.psi.PsiAnnotation
Expand All @@ -52,15 +52,15 @@ class LocalArgsOnlyInspection : MixinInspection() {
val parameter = localAnnotation.parentOfType<PsiParameter>() ?: return
val method = parameter.findContainingMethod() ?: return

val targets = method.annotations.mapFirstNotNull { annotation ->
val targets = method.annotations.flatMap { annotation ->
MixinAnnotationHandler.resolveTarget(annotation).asSequence()
.filterIsInstance<MethodTargetMember>()
.map { it.classAndMethod }
} ?: return
}.ifEmpty { return }

val localType = parameter.type.unwrapLocalRef()

if (ModifyVariableArgsOnlyInspection.shouldReport(localAnnotation, localType, targets)) {
if (ModifyVariableArgsOnlyInspection.shouldReport(localAnnotation, localType, targets.asSequence())) {
holder.registerProblem(
localAnnotation.nameReferenceElement ?: localAnnotation,
"@Local may be argsOnly = true",
Expand Down