NeoModDevGradleModelBuilderImpl: Only get version if not in vanilla mode#2594
Merged
Earthcomputer merged 1 commit intominecraft-dev:devfrom Mar 21, 2026
Merged
Conversation
Earthcomputer
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModDevGradle, for whatever reason, throws if you get the version when it's in vanilla mode. Since MCDev currently fetches the version no matter what, this makes it impossible to use vanilla projects with MCDev.
This PR makes it check the NeoForm version first (which is only there if it's a vanilla project), then only if it is confirmed to not be a vanilla project gets the NeoForge version.
I'm also making a PR for MDG to not throw an exception when getting the version, because that's a huge contract violation, but that is not guaranteed to go through. In the meantime, this will let people work on vanilla projects.
Fixes #2570