Merged
Conversation
Configuration should be explicit pre-execution, and after the call to Run a PipelineRunner controls the PipelineOptions of the executions. Runtime access to options is unaffected by this change.
Jdbc k8 script: postgres data store only accessible inside test project Jdbc k8 & data loading: add teardown and update names/docs
Remove timeout since it is already a pipeline option. Advance to infinity at the end of pipelines. Add EOT watermark and expected assertions test options. SparkPipelineResult should avoid returning null, and handle exceptions better. Make ResumeFromCheckpointStreamingTest use TestSparkRunner and stop on EOT watermark. Stop the context and update the state in finally. Addressed comments - better name for a watermark that stops execution.
We now set the GC timer for window.maxTimestamp() + 1 to ensure that a user timer set for window.maxTimestamp() still has all state. This also adds tests for late data dropping and state GC specifically for the Flink DoFnOperator.
[BEAM-797] Remove unnecessary temp dir from test
… examples runnable
This brings parity between Create.Values and Create.TimestampedValues. Update CreateTest to ensure that create coder inference would fail if it ran.
Incorporate a BeamArgumentParser (argparse.ArgumentParser + ValueProviders). Add StaticValueProvider and RuntimeValueProvider derived from ValueProvider. Add serialization for ValueProvider objects. Add testing for ValueProvider objects. Modify FileBasedSource and FileSink to accept ValueProvider objects.
This reverts commit b43eea4.
mingmxu
pushed a commit
that referenced
this pull request
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.