Undeprecate v2 metrics #1375
Merged
Undeprecate v2 metrics #1375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feorlen
commented
Nov 27, 2024
Comment on lines
58
to
59
| [--api_version v3] \ | ||
| [TYPE --bucket <bucket name> --api_version v3] |
Collaborator
Author
There was a problem hiding this comment.
maybe there's a better way to specify the v3 only options? 🤔
feorlen
commented
Nov 27, 2024
feorlen
commented
Nov 27, 2024
djwfyi
approved these changes
Nov 27, 2024
Collaborator
djwfyi
left a comment
djwfyi
left a comment
There was a problem hiding this comment.
Some wording suggestions for your consideration.
Don't feel the need to see it again unless you want me to.
source/operations/monitoring/collect-minio-metrics-using-prometheus.rst
Outdated
Show resolved
Hide resolved
source/reference/minio-mc-admin/mc-admin-prometheus-metrics.rst
Outdated
Show resolved
Hide resolved
source/reference/minio-mc-admin/mc-admin-prometheus-metrics.rst
Outdated
Show resolved
Hide resolved
source/reference/minio-mc-admin/mc-admin-prometheus-metrics.rst
Outdated
Show resolved
Hide resolved
source/reference/minio-mc-admin/mc-admin-prometheus-metrics.rst
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Fyi failed check is because unrelated CI work in progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics version 2 is not dead. Continue to feature v3, but restore the v2 info as an alternate version.
Out of scope:
Updating the Prometheus and InfluxDB procedures. For now, note they are v2 and deal with it in a separate PR.
Staged
http://192.241.195.202:9000/staging/metrics-v2-not-deprecated/linux/operations/monitoring/metrics-and-alerts.html
http://192.241.195.202:9000/staging/metrics-v2-not-deprecated/linux/reference/minio-mc-admin/mc-admin-prometheus.html