Conversation
|
Who is returning with custom namespaces? |
|
Which server? |
|
Hey! It's an on-premise solution. It actually doesn't return with a namespace at all but thought it'd be better to keep it open for custom namespaces, happy to change to a toggle if you feel that would be better 🙂 Unfortunately I can't speak to the specifics of the solution due to my place of work, but happy to talk around it as best I can |
There was a problem hiding this comment.
We don't accept new feature changes without one or more functional test/s added in Minio.Functional.Tests to test the new functionality for CI testing.
Besides, the current changes are not enough for the functionality to work. There are quite many references to http://s3.amazonaws.com/doc/2006-03-01/ in the code, and unfortunately they are all hard coded.
So, they all need to be fixed for the custom name space to be taken into account.
|
Hey @ebozduman, That's completely understandable. I'll make the needed changes when I'm able 👍 |
There are some cases where the XML returned via the
ListObjectsEnumAsyncmethod doesn't have the Amazon S3 namespace. This is causing the code to return an empty list every time. This is a small change to allow for custom namespaces when using S3 that don't use the Amazon namespace.I've purposely made it opt-in, so that the original functionality is preserved.